MAINT: Handle warnings in tutorials #203
Conversation
Good point - though I think there's a broader discussion to be had here. IMO the most important thing is supporting the latest releases. I'm not sure there's as much value in supporting the oldest devs. |
I'm thinking mostly about end users who may stuck on older systems without the ability (or in fact the need) to upgrade versions to try to run a tutorial. Not sure how much this is a real concern. |
Yeah that's a good point, and it jives with some of the other unofficial policies that the tutorials have adopted; e.g. not using sphinx-specific features (like intersphinx) in the tutorials themselves so they're still 100% functional as standalone notebooks. There's definitely a wider discussion to be had :) |
|
What about getting in the try/except to make the current CI setup happy, and then discussing what would be sensible to do down the road? |
rossbar
force-pushed
the
maint/deprecations-in-deps
branch
from
289b20d
to
860ba4a
Compare
content/x_y-squared.npz
Outdated
There was a problem hiding this comment.
Hmm, this file is created by the notebook and then read back, so don't add it to the repo.
There was a problem hiding this comment.
Yeah, I must've caught it in a git commit -a. The file is already tracked, but it definitely shouldn't be. I'll make sure to back out the "changes" to the file here. We should remove it entirely from being tracked in a separate PR IMO.
There was a problem hiding this comment.
I got bitten early on with git commit -a when working with submodules that I never use it ever :)
rossbar
force-pushed
the
maint/deprecations-in-deps
branch
from
7c00c61
to
db5a326
Compare
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
|
Thanks @rossbar! |
General maintenance to remove warnings from running the notebooks, including handling deprecated functions in scipy, which just released and rc for 1.12.
As noted in #154, failing on runtime warnings is not currently baked into CI. The way that I did this locally was to convert the tutorials into pure python files:
Then run each of the python files with
-Werror:It's not perfect, but maybe something along these lines could be added to CI to resolve #154